Re: [RFC v5 05/18] gdb/python: add function () method to gdb.Type object

[Tom Tromey <tom@tromey.com>]

>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:

Jan> +/* See gdbtypes.h.  */
Jan> +
Jan> +bool
Jan> +type::is_void ()
Jan> +{
Jan> +  return check_typedef (this)->code () == TYPE_CODE_VOID;
Jan> +}

This should be moved to the earlier patch that calls it.

Jan> +const std::string
Jan> +type::printable_name () const
Jan> +{

This isn't called in this patch but I don't think it really matters as
long as it's used eventually.

Jan> +  string_file thetype;
Jan> +
Jan> +  current_language->print_type (const_cast<type*>(this), "",

Space before "(this)"

Jan> +	  param_types[i] = type_object_to_type (param_type_obj);
Jan> +	  if (param_types[i] == nullptr)
Jan> +	    {
Jan> +	      PyErr_Format (PyExc_TypeError,
Jan> +			    _("Argument at index %d is %s, not a gdb.Type "
Jan> +			      "object."),
Jan> +			    i, Py_TYPE (param_type_obj)->tp_name);
Jan> +	      return nullptr;

It's kind of lame that we don't have a type_object_to_type_checked
variant.

Jan> +	  if (param_types[i]->is_void ())

Can check_typedef throw an exception?  If so this must be wrapped in a
try/catch.  That's a good practice for all calls into gdb anyway,
because things like this may change over time.

Jan> +  if (kw != nullptr)
Jan> +    {
Jan> +      if (!PyDict_Check (kw))
Jan> +	{
Jan> +	  PyErr_Format (PyExc_ValueError,
Jan> +			_("Arguments is %s, not a dict."),
Jan> +			Py_TYPE (args)->tp_name);
Jan> +	  return nullptr;
Jan> +	}
Jan> +

This code should probably call PyArg_ValidateKeywordArguments.
I don't know whether that includes the PyDict_Check on its own.

Jan> +  /* Copy all objfile-owned types to arch. This way user does not
Jan> +     need to care about mixing types from different objfiles and
Jan> +     architectures and we do not need to expose this implementation
Jan> +     detail to the user.  */
Jan> +
Jan> +  copied_types_hash_t copied_types;
Jan> +  return_type = copy_type_recursive (return_type, copied_types);

This whole block should probably be wrapped in a try/catch.

Jan> +	function_type = lookup_function_type_with_arguments
Jan> +	       (return_type, param_types.size (), param_types.data ());

May be mildly nicer to use an array_view here.

Jan> +  gdb_test "python print(repr(int_t.function(varargs=True)))" \
Jan> +      "<gdb.Type code=TYPE_CODE_FUNC name=int \\(void\\)>"
Jan> +
Jan> +  gdb_test "python print(repr(int_t.function(varargs=False)))" \
Jan> +      "<gdb.Type code=TYPE_CODE_FUNC name=int \\(void\\)>"

Seems weird that these print the same thing.

Tom