[RFC v5 03/18] gdb: update is_addr_in_objfile to support "dynamic" objfiles

[Jan Vrany <jan.vrany@labware.com>]

While working with objfiles in Python I noticed that
gdb.Progspace.objfile_for_address () does not return "dynamic" objfiles
created by (for example) GDB's JIT reader API.

This is because is_addr_in_objfile() checks if a given address falls into
any (mappped) section of that objfile. However objfiles created by JIT
reader API do not have sections.

To solve this issue, this commit updates is_addr_in_objfile() to also
check if the address fall into any compunit in that objfile. It does so
only if the objfile has no sections.

Approved-By: Tom Tromey <tom@tromey.com>
---
 gdb/objfiles.c                        | 14 ++++++++++++++
 gdb/objfiles.h                        |  7 +++++++
 gdb/testsuite/gdb.base/jit-reader.exp |  9 +++++++++
 3 files changed, 30 insertions(+)

diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index d25d1a02cea..6d5dd588f91 100644
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -1135,6 +1135,20 @@ is_addr_in_objfile (CORE_ADDR addr, const struct objfile *objfile)
       if (osect->contains (addr))
 	return true;
     }
+  /* Objfiles created dynamically by JIT reader API (and possibly by
+     other means too) do not have sections and therefore the above
+     check never succeeds.
+
+     For such "dynamic" objfiles walk over all compunits and check
+     if any of them contains given ADDR.  */
+  if (objfile->sections_start == nullptr)
+    {
+      for (const compunit_symtab *cu : objfile->compunits ())
+	{
+	  if (cu->maybe_contains (addr))
+	    return true;
+	}
+    }
   return false;
 }
 
diff --git a/gdb/objfiles.h b/gdb/objfiles.h
index 0206b49e00c..cadb4525782 100644
--- a/gdb/objfiles.h
+++ b/gdb/objfiles.h
@@ -459,6 +459,13 @@ struct objfile : intrusive_list_node<objfile>
     return compunit_symtab_range (compunit_symtabs);
   }
 
+  /* Const version of the function above.  */
+
+  compunit_symtab_range compunits () const
+  {
+    return compunit_symtab_range (compunit_symtabs);
+  }
+
   /* A range adapter that makes it possible to iterate over all
      minimal symbols of an objfile.  */
 
diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp
index 4462ab4aa65..8399558403a 100644
--- a/gdb/testsuite/gdb.base/jit-reader.exp
+++ b/gdb/testsuite/gdb.base/jit-reader.exp
@@ -233,6 +233,15 @@ proc jit_reader_test {} {
 		gdb_test "python print( \[o for o in gdb.objfiles() if o.filename.startswith('<< JIT compiled code')\]\[0\].build_id )" \
 		    "None" \
 		    "python gdb.Objfile.build_id"
+
+		# Check that Progspace.objfile_for_address () finds "jitted"
+		# objfile
+		gdb_test "frame 0" \
+		    "#0  $hex in jit_function_stack_mangle ()$any" \
+		    "select frame 0"
+		gdb_test "python print( gdb.current_progspace().objfile_for_address(gdb.parse_and_eval('\$pc')) )" \
+		    "<gdb.Objfile filename=<< JIT compiled code at $hex >>>" \
+		    "python gdb.Progspace.objfile_for_address"
 	    }
 	}
     }
-- 
2.47.2