From: Tom Tromey <tom@tromey.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, d: Fix PR 33200 - Segfault in d_lookup_symbol
Date: Thu, 31 Jul 2025 10:52:23 -0600 [thread overview]
Message-ID: <87y0s4qp4o.fsf@tromey.com> (raw)
In-Reply-To: <20250730114229.1385610-1-ibuclaw@gdcproject.org> (Iain Buclaw's message of "Wed, 30 Jul 2025 13:42:29 +0200")
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Hi. Thanks for the patch.
Iain> The asm test was generated by namelessclass.d, with the name of the
Iain> class removed to synthesize the failure.
It's strongly preferred to use the "DWARF assembler", if possible, for
tests like this. There was a script posted to the list that helps
convert a .o to the corresponding Tcl code... which reminds me to go
find out what happened to that.
Iain> + /* If type name is NULL, abandon trying to find this symbol. */
Iain> + if (type->name () == NULL)
Iain> + return {};
We're using 'nullptr' in new code.
Tom
next prev parent reply other threads:[~2025-07-31 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 11:42 Iain Buclaw
2025-07-31 16:52 ` Tom Tromey [this message]
2025-07-31 18:25 ` Iain Buclaw
2025-07-31 23:09 ` [PATCH v2] " Iain Buclaw
2025-08-04 17:22 ` Tom Tromey
2025-08-04 17:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0s4qp4o.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=ibuclaw@gdcproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox