Re: [PATCH] gdb, d: Fix PR 33200 - Segfault in d_lookup_symbol

[Iain Buclaw <ibuclaw@gdcproject.org>]

Excerpts from Tom Tromey's message of Juli 31, 2025 6:52 pm:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
> 
> Hi.  Thanks for the patch.
> 
> Iain> The asm test was generated by namelessclass.d, with the name of the
> Iain> class removed to synthesize the failure.
> 
> It's strongly preferred to use the "DWARF assembler", if possible, for
> tests like this.  There was a script posted to the list that helps
> convert a .o to the corresponding Tcl code... which reminds me to go
> find out what happened to that.
> 

I did think about using Dwarf::assemble, some guidance might be required 
on getting it right if I were to resort to hand writing it.

If such a script were committed to ./contrib, that would be extremely 
helpful, there's another patch I have for PR 33201 which again is only 
reproducible in gdc's "d21" compiler proper (it's mixed C++ and D, so 
the assumption is the D support code is dealing with debug generated by 
g++), so a contrived test needs to be written up for that too.

> Iain> +	  /* If type name is NULL, abandon trying to find this symbol.  */
> Iain> +	  if (type->name () == NULL)
> Iain> +	    return {};
> 
> We're using 'nullptr' in new code.
> 

Noted, thanks.

Iain.