From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id W2WxJi22i2hHCgEAWB0awg (envelope-from ) for ; Thu, 31 Jul 2025 14:30:05 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gdcproject.org header.i=@gdcproject.org header.a=rsa-sha256 header.s=MBO0001 header.b=wkxdm6Ct; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 71E441E102; Thu, 31 Jul 2025 14:30:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7A9101E091 for ; Thu, 31 Jul 2025 14:30:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C5ACC3858C74 for ; Thu, 31 Jul 2025 18:30:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5ACC3858C74 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gdcproject.org header.i=@gdcproject.org header.a=rsa-sha256 header.s=MBO0001 header.b=wkxdm6Ct Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by sourceware.org (Postfix) with ESMTPS id C135E3858D3C for ; Thu, 31 Jul 2025 18:25:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C135E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gdcproject.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gdcproject.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C135E3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=80.241.56.151 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753986311; cv=none; b=Fl20tdDsj4qC4UP8xkkaAZlJMKaaZ41CNK3uA1PbBLYGMHjw2FhVv3Hd+9WTcTgtFbLQwg3wRCb2/v29fhjS2CflwZB76vsN8z908yneSoVSNntYmwFRdq+sdom5o33x5R+dyBVtaL54l8ndEyK4bEocJry4jMYzrDbArYhdvO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753986311; c=relaxed/simple; bh=SkTaxHdx4aqh0coZRgDW2rZlrgY39IUUjPCFvrd81DI=; h=DKIM-Signature:Date:From:Subject:To:MIME-Version:Message-Id; b=vUCulRIVCf3Ntaxj9wVlsfyqnzh9Aeg+CTUUrc8WAT2Zvh7C0NA4IFaxus5Z7vbbZLoZjV68MmyUqAD/x3W+E4DdxvsS+6cSz1ONvgFL7CdrSDKMdP7RGIQgtlRsLAeLk0NUymbNyYPZ9jY3OKysWJRNAwE3kHgzhKVwLle4jkg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C135E3858D3C Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4btHYv69H4z9tJF; Thu, 31 Jul 2025 20:25:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gdcproject.org; s=MBO0001; t=1753986307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GsPwsH35QfO8dPuU1T7/e7awCg7VcEPrAysnw9lEF4I=; b=wkxdm6Ct7m8bPwm/RtbvS9mjMGZATi7+nh9QfxPwJ4LvEAHJebx8VpvJSe9pzns4U5sGDF kaigxuY5zA5oY0RxDMWBdM34evsjmGpBfdEmEAhMMsfroxqkDp3v/2NuhXUEYJ7WRUQmgE /40kBXp1o6MofWWzLp/iynC7fNYsVfAZmvjxxU9/8K6jEVVh/0p6MUMS8TZpElcKAkF4Sd IjlvLa7LQDWMIRr/wUViC6jKXMZh7NdHiN7+KthnnOKJl/25O2duC1tiEJEvpie22fLHvq 0WU34i1CHl/4IXmevHA1t67XhcqtSS3FFQwh/ThjKf44FhuhrIxSZvLViVnF+Q== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of ibuclaw@gdcproject.org designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=ibuclaw@gdcproject.org Date: Thu, 31 Jul 2025 20:25:04 +0200 From: Iain Buclaw Subject: Re: [PATCH] gdb, d: Fix PR 33200 - Segfault in d_lookup_symbol To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250730114229.1385610-1-ibuclaw@gdcproject.org> <87y0s4qp4o.fsf@tromey.com> In-Reply-To: <87y0s4qp4o.fsf@tromey.com> MIME-Version: 1.0 Message-Id: <1753985679.4lko1qk7ka.astroid@pulse.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4btHYv69H4z9tJF X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Excerpts from Tom Tromey's message of Juli 31, 2025 6:52 pm: >>>>>> "Iain" =3D=3D Iain Buclaw writes: >=20 > Hi. Thanks for the patch. >=20 > Iain> The asm test was generated by namelessclass.d, with the name of the > Iain> class removed to synthesize the failure. >=20 > It's strongly preferred to use the "DWARF assembler", if possible, for > tests like this. There was a script posted to the list that helps > convert a .o to the corresponding Tcl code... which reminds me to go > find out what happened to that. >=20 I did think about using Dwarf::assemble, some guidance might be required=20 on getting it right if I were to resort to hand writing it. If such a script were committed to ./contrib, that would be extremely=20 helpful, there's another patch I have for PR 33201 which again is only=20 reproducible in gdc's "d21" compiler proper (it's mixed C++ and D, so=20 the assumption is the D support code is dealing with debug generated by=20 g++), so a contrived test needs to be written up for that too. > Iain> + /* If type name is NULL, abandon trying to find this symbol. *= / > Iain> + if (type->name () =3D=3D NULL) > Iain> + return {}; >=20 > We're using 'nullptr' in new code. >=20 Noted, thanks. Iain.