From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z/f8Drufi2h1+gAAWB0awg (envelope-from ) for ; Thu, 31 Jul 2025 12:54:19 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pMXTSpw9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2EE411E102; Thu, 31 Jul 2025 12:54:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1C2C11E091 for ; Thu, 31 Jul 2025 12:54:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 526F33858408 for ; Thu, 31 Jul 2025 16:54:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 526F33858408 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pMXTSpw9 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id D96AC385840D for ; Thu, 31 Jul 2025 16:52:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D96AC385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D96AC385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753980747; cv=none; b=g8utUsFvAIw5P/71cB2BXhENj96R6p8UF0wM6Qg7SOHc1DqSxDvS5kbAwJD0QblCQz9f1iZnnV+ZIseVHcvH7ur6PdDFLivIibi5bKJ9HLfNFFoV62v7i55p1ixYn0cwCfyV5/U/A5bc196k10JEqvXp4BSy2b9vwmMRKNDFF1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753980747; c=relaxed/simple; bh=9VO7Lf8Q4K03bpvCORrBrzXtZrYt1cphNm9bqW5Dk0A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CiieZRFxs6TXMyqQKcbxVnO3IBoK4YIInKzFzM+DZ+NO+U7QR2Uf2Vd9I7Pt6/mB74xDf0ol8oTItiK5r9FBa/8LTN74wierYtAguxEjdsWZPC6jU2WwthzYsXl0FyA0Vke0Xd4YZOZ1Ag2jkCrFi2xPtN5xRpK08E14/gWdXYc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D96AC385840D Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id hR12udMHeuKaFhWW1u32kD; Thu, 31 Jul 2025 16:52:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id hWW0uEZzvrnsYhWW0uyy7d; Thu, 31 Jul 2025 16:52:25 +0000 X-Authority-Analysis: v=2.4 cv=OLkn3TaB c=1 sm=1 tr=0 ts=688b9f49 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Wb1JkmetP80A:10 a=ItBw4LHWJt0A:10 a=8jCL0hXuAAAA:8 a=i5AvGgfGsAoHGi3mgDcA:9 a=b_lFyywqPYlUfrNfzq6h:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=f0xjg22zsrvHLJdko9HwsQ3vRAH+JpGMAG8uo86s5eo=; b=pMXTSpw9kJLTtq6vQ56S2i6IeX 8kwuGwbADnCUsyI9pQYnGuK5iv3ZEHMBIdlahdBuFM1jKg1WzNz3qK8m34C6FN2EY3XB5ldF8ojeX vRezytxsIgAgegNWrTU+PGsHZ; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:49696 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uhWW0-00000000nWJ-0m1F; Thu, 31 Jul 2025 10:52:24 -0600 From: Tom Tromey To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb, d: Fix PR 33200 - Segfault in d_lookup_symbol In-Reply-To: <20250730114229.1385610-1-ibuclaw@gdcproject.org> (Iain Buclaw's message of "Wed, 30 Jul 2025 13:42:29 +0200") References: <20250730114229.1385610-1-ibuclaw@gdcproject.org> X-Attribution: Tom Date: Thu, 31 Jul 2025 10:52:23 -0600 Message-ID: <87y0s4qp4o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uhWW0-00000000nWJ-0m1F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:49696 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPNYK0vpl/iVxEg1IcQKGQ4z7xS1PvW3Vzm+Ec18fQoYZsAl5JcOBU6pymUdfj4CovJSJre4V8FfL1pQrtyK5WCNT05atNT+7uwRyod4cOviH5XCCqjN 9Nnz1dN5GIGUJDmiNeKL+Q7AdYjowE7jL9N1cxBZD+eKr2EpFuw6SN4qgQTH4BDrXyeILQ79MVc3GQ2AwnagAs/C1hrFZL7enS8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Iain" == Iain Buclaw writes: Hi. Thanks for the patch. Iain> The asm test was generated by namelessclass.d, with the name of the Iain> class removed to synthesize the failure. It's strongly preferred to use the "DWARF assembler", if possible, for tests like this. There was a script posted to the list that helps convert a .o to the corresponding Tcl code... which reminds me to go find out what happened to that. Iain> + /* If type name is NULL, abandon trying to find this symbol. */ Iain> + if (type->name () == NULL) Iain> + return {}; We're using 'nullptr' in new code. Tom