Re: [PATCH v3 6/7] gdb/python: add gdbpy_dict_wrapper:allocate_dict helper

[Tom Tromey <tom@tromey.com>]

>>>>> Matthieu Longo <matthieu.longo@arm.com> writes:

> Python extension objects that support __dict__ must inherit from
> gdbpy_dict_wrapper, a wrapper class that stores the PyObject
> corresponding to the __dict__ attribute.

> Currently, management of this dictionary is not centralized, and
> each Python extension object implements its own logic to create,
> access, and destroy it.

> This patch focuses on the allocation of the dictionary, introduces
> a new method, gdbpy_dict_wrapper::allocate_dict(), and
> adapts the existing code to use this method.

A nit.

> +
> +  bool
> +  allocate_dict ()
> +  {

This should have an intro comment.
And, the type and name should appear on the same line, that's the style
for methods.

Ok with that change.
Approved-By: Tom Tromey <tom@tromey.com>

Tom