Re: [PATCH v3 5/7] gdb/python: flatten functions calling PyObject_New and use gdbpy_ref

[Tom Tromey <tom@tromey.com>]

>>>>> Matthieu Longo <matthieu.longo@arm.com> writes:

> This patch aims at systematically using gdbpy_ref<> at all call sites
> of PyObject_New(). This prepares for future patches that expect
> gdbby_ref<> parameters and affect return handling.
> As part of this change, flattening the affected functions so that the
> return logic becomes clearer and more flexible to adjust.

Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

> +  /* PyObject_New initializes the new object with a refcount of 1.  This counts
> +     for the reference we are keeping in the inferior corefile data.  */
> +  cfpy_inferior_corefile_data_key.set (inf, object.get ());
 
> -  return gdbpy_ref<>::new_reference (result);
> +  return gdbpy_ref<>::new_reference (object.release ());

Ok, now I see what you meant here.
It's a bit confusing without context since the .release really "should"
appear at the original assignment.  But this is equivalent.

Tom