Re: [PATCH v3 1/7] gdb: introduce rgb_color type to simplify existing code

[Tom Tromey <tom@tromey.com>]

>>>>> Matthieu Longo <matthieu.longo@arm.com> writes:

>> It seems to be because an rgb_color can be implicitly converted to a
>> `uint8_t *`, which can be subscripted, but also has an operator[].
>> Not sure why the uint8_t* operator is needed,

First, sorry about that, I missed the implicit conversion in my review.
While I think those can be ok sometimes, most of the times they aren't.

>   rgb = palette_8colors[m_value];

>> but it compiles fine here if I remove it.  If really needed, I think that an explicit method
>> (`.data()`) would be preferable, to avoid unwanted conversions.

> I locally tested the removal of this uint8_t* operator, and the code compiles fine.

> Do you want me to publish a patch for this ? Or will you fix it ?

Please send it as a patch with an appropriate commit message.
It's pre-approved by me.  Though TBH this could probably also be obvious
considering it's a one-line removal and fixes the build.

You can add the tag - 
Approved-By: Tom Tromey <tom@tromey.com>

thank you,
Tom