From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Build gdb "nat" files in subdirectory
Date: Thu, 27 Dec 2018 20:03:00 -0000 [thread overview]
Message-ID: <87wonuohz5.fsf@tromey.com> (raw)
In-Reply-To: <a94ae4ba-eb79-876a-593d-0eeeb0da92a1@simark.ca> (Simon Marchi's message of "Wed, 26 Dec 2018 23:29:21 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> I wrote a small script scraping all .o file names from configure.nat, to
Simon> see if there is a corresponding .c file (see below if you need it). The
Simon> only bad one it found is "nat/aarch64-sve-nat/linux-ptrace.o", which should
Simon> just be nat/linux-ptrace.o, I think.
Thanks for doing that. I think the one bad one should be
nat/aarch64-sve-linux-ptrace.o, so I've made that change.
Simon> Other than that, it did fine the _U/_S files for Hurd (e.g. notify_S.o). There
Simon> is no corresponding .c file for that, I don't know if they are generated or what,
Simon> but I don't think your patch changes anything about that.
I believe they are generated in the build tree.
Simon> Overall this series LGTM, thanks!
I'm going to push the updated series. Thanks for the review.
Tom
next prev parent reply other threads:[~2018-12-27 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 21:09 [PATCH 0/3] some minor Makefile improvements Tom Tromey
2018-12-24 21:09 ` [PATCH 3/3] Build gdb "nat" files in subdirectory Tom Tromey
2018-12-27 4:29 ` Simon Marchi
2018-12-27 20:03 ` Tom Tromey [this message]
2018-12-24 21:10 ` [PATCH 1/3] Remove gdbtypes special case from init.c rule Tom Tromey
2018-12-24 21:10 ` [PATCH 2/3] Make init.c depend on source files Tom Tromey
2018-12-27 4:02 ` Simon Marchi
2018-12-27 4:21 ` Tom Tromey
2018-12-27 4:23 ` Simon Marchi
2018-12-27 4:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wonuohz5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox