From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126926 invoked by alias); 27 Dec 2018 20:03:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126877 invoked by uid 89); 27 Dec 2018 20:03:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=overall X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Dec 2018 20:03:16 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 9A6C255645 for ; Thu, 27 Dec 2018 14:03:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cbs9g6qfu2PzOcbs9goq1L; Thu, 27 Dec 2018 14:03:13 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gzXjIybPyeVh7X+e6m1gLldZicxFTTWFHRkjrgvh1M8=; b=t2hF7cIdtL0HQTA4Mwpzf/Won4 /jC2CW6ctncqeui5J5PkALZKoBxCYzU+GBY/FfiBXj4ZyDyq1DvFVDJZx3/46yb95gxUn+9+8s4Q8 IUJhEFuFGqFBkpRNOepUL5wL9; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:59734 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gcbs9-000Br6-DQ; Thu, 27 Dec 2018 14:03:13 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Build gdb "nat" files in subdirectory References: <20181224210927.16741-1-tom@tromey.com> <20181224210927.16741-4-tom@tromey.com> Date: Thu, 27 Dec 2018 20:03:00 -0000 In-Reply-To: (Simon Marchi's message of "Wed, 26 Dec 2018 23:29:21 -0500") Message-ID: <87wonuohz5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00380.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I wrote a small script scraping all .o file names from configure.nat, to Simon> see if there is a corresponding .c file (see below if you need it). The Simon> only bad one it found is "nat/aarch64-sve-nat/linux-ptrace.o", which should Simon> just be nat/linux-ptrace.o, I think. Thanks for doing that. I think the one bad one should be nat/aarch64-sve-linux-ptrace.o, so I've made that change. Simon> Other than that, it did fine the _U/_S files for Hurd (e.g. notify_S.o). There Simon> is no corresponding .c file for that, I don't know if they are generated or what, Simon> but I don't think your patch changes anything about that. I believe they are generated in the build tree. Simon> Overall this series LGTM, thanks! I'm going to push the updated series. Thanks for the review. Tom