Re: [PATCH 3/3] Build gdb "nat" files in subdirectory

Tom Tromey
2018-12-27T20:03:23Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I wrote a small script scraping all .o file names from configure.nat, to
Simon> see if there is a corresponding .c file (see below if you need it). The
Simon> only bad one it found is "nat/aarch64-sve-nat/linux-ptrace.o", which should
Simon> just be nat/linux-ptrace.o, I think.

Thanks for doing that. I think the one bad one should be
nat/aarch64-sve-linux-ptrace.o, so I've made that change.

Simon> Other than that, it did fine the _U/_S files for Hurd (e.g. notify_S.o). There
Simon> is no corresponding .c file for that, I don't know if they are generated or what,
Simon> but I don't think your patch changes anything about that.

I believe they are generated in the build tree.

Simon> Overall this series LGTM, thanks!

I'm going to push the updated series. Thanks for the review.

Tom