From: Tom Tromey <tom@tromey.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 2/4] gdbserver: Add debug-file option
Date: Tue, 16 Apr 2019 19:39:00 -0000 [thread overview]
Message-ID: <87wojtsprv.fsf@tromey.com> (raw)
In-Reply-To: <20190416101729.16176-3-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 16 Apr 2019 10:17:41 +0000")
>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
Alan> Add command line option to send all debug output to a given file.
Alan> Always default back to stderr.
Alan> Add matching monitor command. Add documentation.
Thanks. The code parts of this are ok.
One little nit:
Alan> + debug_file = fptr;
Alan> + return;
Alan> +}
...this "return;" can be removed.
Tom
next prev parent reply other threads:[~2019-04-16 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190416101729.16176-1-alan.hayward@arm.com>
2019-04-16 10:17 ` Alan Hayward
2019-04-16 19:39 ` Tom Tromey [this message]
[not found] ` <83o956ggdw.fsf@gnu.org>
2019-04-17 9:39 ` Alan Hayward
2019-04-16 14:44 ` [PATCH 0/4] gdbserver/testsuite : Capture gdbserver debug output during testing Eli Zaretskii
[not found] ` <20190416101729.16176-2-alan.hayward@arm.com>
2019-04-16 19:31 ` [PATCH 1/4] gdbserver: Move remote_debug to a single place Tom Tromey
[not found] ` <20190416101729.16176-4-alan.hayward@arm.com>
2019-04-16 19:43 ` [PATCH 3/4] gdbserver: Ensure all debug output uses debug functions Tom Tromey
2019-06-19 9:30 ` Tom de Vries
2019-06-19 13:17 ` Tom Tromey
[not found] ` <20190416101729.16176-5-alan.hayward@arm.com>
2019-04-16 19:49 ` [PATCH 4/4] testsuite: Add option to capture gdbserver debug Tom Tromey
2019-04-17 15:43 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wojtsprv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox