From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97831 invoked by alias); 16 Apr 2019 19:39:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97793 invoked by uid 89); 16 Apr 2019 19:39:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.152.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Apr 2019 19:39:50 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 5655214840 for ; Tue, 16 Apr 2019 14:39:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GTvphbyrSiQerGTvphKSKF; Tue, 16 Apr 2019 14:39:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n+bVmQ2gjxeVDvY3bKmMi2JVjNH8plCmc4kZtbRtB0w=; b=dgF00qPnAh2kHpUkRIB8iahhVz dSrx//QD69lrM4xBD96o3YvjGjgTR4ald80FGCIFND4cwU1QllebSRhaUZtJNsFpquYTd4IiY/Xeg Y19N5Bdwkzd0IxsSKeedDS2kj; Received: from 75-166-39-124.hlrn.qwest.net ([75.166.39.124]:45766 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hGTvp-004E6V-3A; Tue, 16 Apr 2019 14:39:49 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 2/4] gdbserver: Add debug-file option References: <20190416101729.16176-1-alan.hayward@arm.com> <20190416101729.16176-3-alan.hayward@arm.com> Date: Tue, 16 Apr 2019 19:39:00 -0000 In-Reply-To: <20190416101729.16176-3-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 16 Apr 2019 10:17:41 +0000") Message-ID: <87wojtsprv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00276.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> Add command line option to send all debug output to a given file. Alan> Always default back to stderr. Alan> Add matching monitor command. Add documentation. Thanks. The code parts of this are ok. One little nit: Alan> + debug_file = fptr; Alan> + return; Alan> +} ...this "return;" can be removed. Tom