Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 nd <nd@arm.com>
Subject: Re: [PATCH 1/4] gdbserver: Move remote_debug to a single place
Date: Tue, 16 Apr 2019 19:31:00 -0000	[thread overview]
Message-ID: <871s21u4pl.fsf@tromey.com> (raw)
In-Reply-To: <20190416101729.16176-2-alan.hayward@arm.com> (Alan Hayward's	message of "Tue, 16 Apr 2019 10:17:41 +0000")

>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

Alan> Also removes the unused gdb_stdlog variable.

I looked and this is referenced from common/observable.h; but I suppose
that could be converted to use debug_vprintf or similar if it's ever
used in gdbserver.

Alan> 2019-04-16  Alan Hayward  <alan.hayward@arm.com>
Alan> 	* debug.c (remote_debug): Add definition.
Alan> 	* debug.h (remote_debug): Add declaration.
Alan> 	* hostio.c (remote_debug): Remove declaration.
Alan> 	* remote-utils.c (struct ui_file): Likewise.
Alan> 	(remote_debug): Likewise.
Alan> 	* remote-utils.h (remote_debug): Likewise,
Alan> 	* server.c (remote_debug): Remove definition.

Thanks, this is ok.

Tom


  parent reply	other threads:[~2019-04-16 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190416101729.16176-1-alan.hayward@arm.com>
2019-04-16 10:17 ` [PATCH 2/4] gdbserver: Add debug-file option Alan Hayward
2019-04-16 19:39   ` Tom Tromey
     [not found]   ` <83o956ggdw.fsf@gnu.org>
2019-04-17  9:39     ` Alan Hayward
2019-04-16 14:44 ` [PATCH 0/4] gdbserver/testsuite : Capture gdbserver debug output during testing Eli Zaretskii
     [not found] ` <20190416101729.16176-2-alan.hayward@arm.com>
2019-04-16 19:31   ` Tom Tromey [this message]
     [not found] ` <20190416101729.16176-4-alan.hayward@arm.com>
2019-04-16 19:43   ` [PATCH 3/4] gdbserver: Ensure all debug output uses debug functions Tom Tromey
2019-06-19  9:30     ` Tom de Vries
2019-06-19 13:17       ` Tom Tromey
     [not found] ` <20190416101729.16176-5-alan.hayward@arm.com>
2019-04-16 19:49   ` [PATCH 4/4] testsuite: Add option to capture gdbserver debug Tom Tromey
2019-04-17 15:43     ` Alan Hayward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s21u4pl.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox