From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90692 invoked by alias); 16 Apr 2019 19:31:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90682 invoked by uid 89); 16 Apr 2019 19:31:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:751 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.194.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Apr 2019 19:31:52 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 032D3401A2A2E for ; Tue, 16 Apr 2019 13:49:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GTo7hM0evYTGMGTo7hTVz6; Tue, 16 Apr 2019 14:31:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DDWQcKee/T6TDDIGg/Bv/NaqOKtmpkr6XUmMs21bhks=; b=kLvs3/yduziRH9HQ25wnIBj8pf rc1gXn8I3VL3jxl2oph4kovarzlb2S/v4TQ2YOvExKEV8baRIUk//1+LUc5xBGLeTW17v1o1k0rUV YTyEfwnG1KT7TX+C+iZaTemWW; Received: from 75-166-39-124.hlrn.qwest.net ([75.166.39.124]:45712 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hGTo7-004Bsi-3H; Tue, 16 Apr 2019 14:31:51 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 1/4] gdbserver: Move remote_debug to a single place References: <20190416101729.16176-1-alan.hayward@arm.com> <20190416101729.16176-2-alan.hayward@arm.com> Date: Tue, 16 Apr 2019 19:31:00 -0000 In-Reply-To: <20190416101729.16176-2-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 16 Apr 2019 10:17:41 +0000") Message-ID: <871s21u4pl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00275.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> Also removes the unused gdb_stdlog variable. I looked and this is referenced from common/observable.h; but I suppose that could be converted to use debug_vprintf or similar if it's ever used in gdbserver. Alan> 2019-04-16 Alan Hayward Alan> * debug.c (remote_debug): Add definition. Alan> * debug.h (remote_debug): Add declaration. Alan> * hostio.c (remote_debug): Remove declaration. Alan> * remote-utils.c (struct ui_file): Likewise. Alan> (remote_debug): Likewise. Alan> * remote-utils.h (remote_debug): Likewise, Alan> * server.c (remote_debug): Remove definition. Thanks, this is ok. Tom