Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Norbert Lange <nolange79@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] always export the symbols for the proc_service interface
Date: Mon, 06 Jan 2020 16:07:00 -0000	[thread overview]
Message-ID: <87woa4po0q.fsf@tromey.com> (raw)
In-Reply-To: <20200104202004.83439-2-nolange79@gmail.com> (Norbert Lange's	message of "Sat, 4 Jan 2020 21:20:04 +0100")

>>>>> "Norbert" == Norbert Lange <nolange79@gmail.com> writes:

Norbert> Compiling GDB with '-fvisibility=hidden' will remove the
Norbert> symbols that should be exported.
Norbert> This patch explicitly marks them as visible.

Norbert> gdb/ChangeLog

Norbert> 	PR build/24805
Norbert>         * gdbsupport/gdb_proc_service.h: push/pop visibility
Norbert>         attribute for exported functions.

Thanks for the patch.

I have one question and one comment.

Norbert> +++ b/gdb/gdbsupport/gdb_proc_service.h
Norbert> @@ -23,6 +23,11 @@
 
Norbert>  #ifdef HAVE_PROC_SERVICE_H
 
Norbert> +/* ensure the symbols are public, even if the default is hidden */

In the gdb style, comments should be complete sentences, which end in a
period followed by 2 spaces.  So this should read:

/* Ensure the symbols are public, even if the default is hidden.  */

Norbert> +#if __GNUC__ >= 4
Norbert> +#pragma GCC visibility pop
Norbert> +#endif

Would it be better to just have this done a single time at the top and
bottom of the file?

thanks,
Tom


  reply	other threads:[~2020-01-06 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-04 20:20 [PATCH][PR build/24805] Explicitly export symbols from gdb_proc_service Norbert Lange
2020-01-04 20:20 ` [PATCH] always export the symbols for the proc_service interface Norbert Lange
2020-01-06 16:07   ` Tom Tromey [this message]
2020-01-06 23:22     ` Norbert Lange
2020-01-06 19:21 ` [PATCH][PR build/24805] Explicitly export symbols from gdb_proc_service Pedro Alves
2020-01-06 23:39   ` Norbert Lange
2020-01-14 15:47     ` Pedro Alves
2020-01-14 16:28       ` Pedro Alves
2020-01-14 16:57         ` Norbert Lange
2020-01-16 19:56           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woa4po0q.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nolange79@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox