From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16910 invoked by alias); 6 Jan 2020 16:07:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16864 invoked by uid 89); 6 Jan 2020 16:07:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.231) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2020 16:07:04 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 096D630F319 for ; Mon, 6 Jan 2020 10:07:03 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oUuEiaVwI4kpjoUuEi4ZPf; Mon, 06 Jan 2020 10:07:03 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hne5EQpAD13fznLpOofOghSL+0HnjyZtgzYo2AQ6gqU=; b=UJXb9qNavoUmkQkIzSZEQTsZ+I Q85w49edtBwOCZFPbr/Sja2pipCYAxz2jmHx+RGod/m3noXiUFPunGkF25Zq9WzGwdSsCj83/8PjR okPlwAnFrmmMoqrvgASZoqKf6; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:46586 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ioUuD-0007vs-Sx; Mon, 06 Jan 2020 09:07:01 -0700 From: Tom Tromey To: Norbert Lange Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] always export the symbols for the proc_service interface References: <20200104202004.83439-1-nolange79@gmail.com> <20200104202004.83439-2-nolange79@gmail.com> Date: Mon, 06 Jan 2020 16:07:00 -0000 In-Reply-To: <20200104202004.83439-2-nolange79@gmail.com> (Norbert Lange's message of "Sat, 4 Jan 2020 21:20:04 +0100") Message-ID: <87woa4po0q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00117.txt.bz2 >>>>> "Norbert" == Norbert Lange writes: Norbert> Compiling GDB with '-fvisibility=hidden' will remove the Norbert> symbols that should be exported. Norbert> This patch explicitly marks them as visible. Norbert> gdb/ChangeLog Norbert> PR build/24805 Norbert> * gdbsupport/gdb_proc_service.h: push/pop visibility Norbert> attribute for exported functions. Thanks for the patch. I have one question and one comment. Norbert> +++ b/gdb/gdbsupport/gdb_proc_service.h Norbert> @@ -23,6 +23,11 @@ Norbert> #ifdef HAVE_PROC_SERVICE_H Norbert> +/* ensure the symbols are public, even if the default is hidden */ In the gdb style, comments should be complete sentences, which end in a period followed by 2 spaces. So this should read: /* Ensure the symbols are public, even if the default is hidden. */ Norbert> +#if __GNUC__ >= 4 Norbert> +#pragma GCC visibility pop Norbert> +#endif Would it be better to just have this done a single time at the top and bottom of the file? thanks, Tom