Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Handle missing gccgo
Date: Wed, 19 Feb 2020 22:33:00 -0000	[thread overview]
Message-ID: <87wo8i8ax3.fsf@tromey.com> (raw)
In-Reply-To: <1abf50d3-a018-0d35-7f58-95b1b2563812@suse.de> (Tom de Vries's	message of "Wed, 19 Feb 2020 22:40:55 +0100")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> If we merge support_go_compile into skip_go_tests, then if gccgo is not
Tom> present, these two tests will not be run, while they could be run.

Tom> WDYT?

Yeah, in that case, I think your original patch is ok.

I considered suggesting that you just remove skip_go_tests from those
two tests.  But, at least Rust testing doesn't work this way -- it
splits skip_rust_tests from compilation failures.

Probably either way is fine, since we're just talking about not running
tests.  But you already have one patch written...

thanks,
Tom


      reply	other threads:[~2020-02-19 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 11:27 Tom de Vries
2020-02-19 21:27 ` Tom Tromey
2020-02-19 21:40   ` Tom de Vries
2020-02-19 22:33     ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo8i8ax3.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox