From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Handle missing gccgo
Date: Wed, 19 Feb 2020 21:40:00 -0000 [thread overview]
Message-ID: <1abf50d3-a018-0d35-7f58-95b1b2563812@suse.de> (raw)
In-Reply-To: <87o8tuqndi.fsf@tromey.com>
On 19-02-2020 22:27, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> if { [skip_go_tests] } { continue }
> Tom> +if { [support_go_compile] == 0 } { continue }
>
> It seems to me that skip_go_tests should simply do this check.
There are two gdb.go tests that don't require gccgo: gdb.go/print.exp
and gdb.go/basic-types.exp.
If we merge support_go_compile into skip_go_tests, then if gccgo is not
present, these two tests will not be run, while they could be run.
WDYT?
Thanks,
- Tom
next prev parent reply other threads:[~2020-02-19 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 11:27 Tom de Vries
2020-02-19 21:27 ` Tom Tromey
2020-02-19 21:40 ` Tom de Vries [this message]
2020-02-19 22:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1abf50d3-a018-0d35-7f58-95b1b2563812@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox