From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32013 invoked by alias); 19 Feb 2020 21:40:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31894 invoked by uid 89); 19 Feb 2020 21:40:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 21:40:57 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A7C41B2E1; Wed, 19 Feb 2020 21:40:55 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Handle missing gccgo To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200219112700.GA17397@delia> <87o8tuqndi.fsf@tromey.com> From: Tom de Vries Message-ID: <1abf50d3-a018-0d35-7f58-95b1b2563812@suse.de> Date: Wed, 19 Feb 2020 21:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87o8tuqndi.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00809.txt.bz2 On 19-02-2020 22:27, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> if { [skip_go_tests] } { continue } > Tom> +if { [support_go_compile] == 0 } { continue } > > It seems to me that skip_go_tests should simply do this check. There are two gdb.go tests that don't require gccgo: gdb.go/print.exp and gdb.go/basic-types.exp. If we merge support_go_compile into skip_go_tests, then if gccgo is not present, these two tests will not be run, while they could be run. WDYT? Thanks, - Tom