From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62254 invoked by alias); 19 Feb 2020 22:33:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62246 invoked by uid 89); 19 Feb 2020 22:33:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.198.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 22:33:31 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id A935940152F10 for ; Wed, 19 Feb 2020 15:47:56 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4XuLjb7f18vkB4XuLjXewQ; Wed, 19 Feb 2020 16:33:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NxIFEsM+c4JsCgQIgEhZZe81MrWEJFtEW1it093LcIk=; b=VjItADbCVh/fwIXUuMb8c3r/2F PPGnYWnW6T7WUkx5oGq1mV/wjnQUXYkvs/eOoHtLEtpn0EnQA+nuwr0lqDTW5hKvXVEbQcHnrBnon 2AFAe/3IIj1eEB0iW3zZcTfCo; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:46320 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j4XuL-002xC0-Fp; Wed, 19 Feb 2020 15:33:29 -0700 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite] Handle missing gccgo References: <20200219112700.GA17397@delia> <87o8tuqndi.fsf@tromey.com> <1abf50d3-a018-0d35-7f58-95b1b2563812@suse.de> Date: Wed, 19 Feb 2020 22:33:00 -0000 In-Reply-To: <1abf50d3-a018-0d35-7f58-95b1b2563812@suse.de> (Tom de Vries's message of "Wed, 19 Feb 2020 22:40:55 +0100") Message-ID: <87wo8i8ax3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00811.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> If we merge support_go_compile into skip_go_tests, then if gccgo is not Tom> present, these two tests will not be run, while they could be run. Tom> WDYT? Yeah, in that case, I think your original patch is ok. I considered suggesting that you just remove skip_go_tests from those two tests. But, at least Rust testing doesn't work this way -- it splits skip_rust_tests from compilation failures. Probably either way is fine, since we're just talking about not running tests. But you already have one patch written... thanks, Tom