Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Kamil Rytarowski <n54@gmx.com>,
	 simark@simark.ca, gdb-patches@sourceware.org
Subject: Re: [PATCH] Disable get_ptrace_pid for NetBSD
Date: Wed, 18 Mar 2020 14:54:27 -0600	[thread overview]
Message-ID: <87wo7htmd8.fsf@tromey.com> (raw)
In-Reply-To: <875zf1v17x.fsf@tromey.com> (Tom Tromey's message of "Wed, 18 Mar 2020 14:48:18 -0600")

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> Why not make just the body of this function

Tom> #ifdef __NetBSD__
Tom>   return ptid.pid ()
Tom> #else
Tom>   ... old code

Tom> That would mean fewer #ifs.

I see that's what you did originally and Simon requested this version.

Personally I think the new patch is uglier than the original, on the
basis that use of "#if" generally makes the code harder to understand.

Tom


  reply	other threads:[~2020-03-18 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 16:29 Kamil Rytarowski
2020-03-18 20:48 ` Tom Tromey
2020-03-18 20:54   ` Tom Tromey [this message]
2020-03-18 21:22     ` Simon Marchi
2020-03-18 21:15 ` Simon Marchi
2020-03-18 21:40   ` Kamil Rytarowski
2020-03-18 21:43     ` Simon Marchi
2020-03-18 21:45       ` Kamil Rytarowski
2020-03-18 21:49 Kamil Rytarowski
2020-03-18 21:51 ` Kamil Rytarowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo7htmd8.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=n54@gmx.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox