From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.46.113]) by sourceware.org (Postfix) with ESMTPS id AC6BF381DCF6 for ; Wed, 18 Mar 2020 20:54:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AC6BF381DCF6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id BD78340168661 for ; Wed, 18 Mar 2020 15:54:28 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id EfhsjBzUSLnBiEfhsjhkkN; Wed, 18 Mar 2020 15:54:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fxSBXVxtEi1esGK0EKua1gmduABL18Zy7O3rZHeYbFE=; b=G66K6DZcgI6383HVurT3HfldRD 0ulGJi8pJNUfTOCxmt0mlul6GFd/79J/9wprZWPvcAyjYhhezdIM9aAwIkBxiUX3d5wOdseIvP7GI 9NbLE7zGhKd9SwzEtpRmO30tr; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:34466 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jEfhs-0020eh-Cj; Wed, 18 Mar 2020 14:54:28 -0600 From: Tom Tromey To: Tom Tromey Cc: Kamil Rytarowski , simark@simark.ca, gdb-patches@sourceware.org Subject: Re: [PATCH] Disable get_ptrace_pid for NetBSD References: <20200318162915.15043-1-n54@gmx.com> <875zf1v17x.fsf@tromey.com> X-Attribution: Tom Date: Wed, 18 Mar 2020 14:54:27 -0600 In-Reply-To: <875zf1v17x.fsf@tromey.com> (Tom Tromey's message of "Wed, 18 Mar 2020 14:48:18 -0600") Message-ID: <87wo7htmd8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jEfhs-0020eh-Cj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (murgatroyd) [97.118.117.21]:34466 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=1.3 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 20:54:30 -0000 >>>>> "Tom" == Tom Tromey writes: Tom> Why not make just the body of this function Tom> #ifdef __NetBSD__ Tom> return ptid.pid () Tom> #else Tom> ... old code Tom> That would mean fewer #ifs. I see that's what you did originally and Simon requested this version. Personally I think the new patch is uglier than the original, on the basis that use of "#if" generally makes the code harder to understand. Tom