From: Kamil Rytarowski <n54@gmx.com>
To: gdb-patches@sourceware.org
Cc: simark@simark.ca, Kamil Rytarowski <n54@gmx.com>
Subject: [PATCH] Disable get_ptrace_pid for NetBSD
Date: Wed, 18 Mar 2020 17:29:15 +0100 [thread overview]
Message-ID: <20200318162915.15043-1-n54@gmx.com> (raw)
Unlike most other Operating Systems, NetBSD tracks both pid and lwp.
The process id on NetBSD is stored always in the pid field of ptid.
gdb/ChangeLog:
* inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
* inf-ptrace.c: Likewise.
* (inf_ptrace_target::resume): Update.
* (inf_ptrace_target::xfer_partial): Likewise.
---
gdb/ChangeLog | 7 +++++++
gdb/inf-ptrace.c | 19 +++++++++++++++++--
gdb/inf-ptrace.h | 2 ++
3 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 84964dc00ac..36e333ec8ba 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2020-03-18 Kamil Rytarowski <n54@gmx.com>
+
+ * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
+ * inf-ptrace.c: Likewise.
+ * (inf_ptrace_target::resume): Update.
+ * (inf_ptrace_target::xfer_partial): Likewise.
+
2020-03-17 Kamil Rytarowski <n54@gmx.com>
* regformats/regdef.h: Put reg in gdb namespace.
diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c
index db17a76d946..e8bf66ed45f 100644
--- a/gdb/inf-ptrace.c
+++ b/gdb/inf-ptrace.c
@@ -313,8 +313,12 @@ inf_ptrace_target::kill ()
target_mourn_inferior (inferior_ptid);
}
+#ifndef __NetBSD__
/* Return which PID to pass to ptrace in order to observe/control the
- tracee identified by PTID. */
+ tracee identified by PTID.
+
+ Unlike most other Operating Systems, NetBSD tracks both pid and lwp
+ and avoids this function. */
pid_t
get_ptrace_pid (ptid_t ptid)
@@ -328,6 +332,7 @@ get_ptrace_pid (ptid_t ptid)
pid = ptid.pid ();
return pid;
}
+#endif
/* Resume execution of thread PTID, or all threads if PTID is -1. If
STEP is nonzero, single-step it. If SIGNAL is nonzero, give it
@@ -344,7 +349,13 @@ inf_ptrace_target::resume (ptid_t ptid, int step, enum gdb_signal signal)
single-threaded processes, so simply resume the inferior. */
pid = inferior_ptid.pid ();
else
- pid = get_ptrace_pid (ptid);
+ {
+#ifdef __NetBSD__
+ pid = ptid. pid();
+#else
+ pid = get_ptrace_pid (ptid);
+#endif
+ }
if (catch_syscall_enabled () > 0)
request = PT_SYSCALL;
@@ -528,7 +539,11 @@ inf_ptrace_target::xfer_partial (enum target_object object,
const gdb_byte *writebuf,
ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
{
+#ifdef __NetBSD__
+ pid_t pid = inferior_ptid. pid();
+#else
pid_t pid = get_ptrace_pid (inferior_ptid);
+#endif
switch (object)
{
diff --git a/gdb/inf-ptrace.h b/gdb/inf-ptrace.h
index dd0733736f2..340d41d8beb 100644
--- a/gdb/inf-ptrace.h
+++ b/gdb/inf-ptrace.h
@@ -78,9 +78,11 @@ struct inf_ptrace_target : public inf_child_target
void detach_success (inferior *inf);
};
+#ifndef __NetBSD__
/* Return which PID to pass to ptrace in order to observe/control the
tracee identified by PTID. */
extern pid_t get_ptrace_pid (ptid_t);
+#endif
#endif
--
2.25.0
next reply other threads:[~2020-03-18 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 16:29 Kamil Rytarowski [this message]
2020-03-18 20:48 ` Tom Tromey
2020-03-18 20:54 ` Tom Tromey
2020-03-18 21:22 ` Simon Marchi
2020-03-18 21:15 ` Simon Marchi
2020-03-18 21:40 ` Kamil Rytarowski
2020-03-18 21:43 ` Simon Marchi
2020-03-18 21:45 ` Kamil Rytarowski
2020-03-18 21:49 Kamil Rytarowski
2020-03-18 21:51 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318162915.15043-1-n54@gmx.com \
--to=n54@gmx.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox