Re: [PATCH 3/3] gdb: change 'maint info section' to use command options

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> The ALLOBJ mechanism is replaced with a real command
Andrew> option (-all-objects).  The rest of the command operates just as
Andrew> before.  The example above would now become:

Andrew>   (gdb) maint info sections -all-objects READONLY

Nice.

Andrew> gdb/ChangeLog:

Andrew> 	* NEWS: Mention changes to 'maint info sections'.
Andrew> 	* maint.c (match_substring): Return a bool, fix whitespace issue.
Andrew> 	(struct single_bfd_flag_info): New struct.
Andrew> 	(bfd_flag_info): New static global.
Andrew> 	(match_bfd_flags): Return a bool, use bfd_flag_info.
Andrew> 	(print_bfd_flags): Use bfd_flag_info.
Andrew> 	(maint_print_section_info): Delete trailing whitespace.
Andrew> 	(struct maint_info_sections_opts): New struct.
Andrew> 	(maint_info_sections_option_defs): New static global.
Andrew> 	(maint_info_sections_completer): New function.
Andrew> 	(maintenance_info_sections): Use option parsing mechanism.
Andrew> 	(_initialize_maint_cmds): Register command completer.

I had one nit here.

Andrew> +/* Vector of all the known bfd flags.  */
Andrew> +
Andrew> +static std::vector<single_bfd_flag_info> bfd_flag_info =
Andrew> +  {

I don't think you need a vector (and thus a static constructor) here.
Instead you can just use a "static const" array.  The for-each
statements will still work fine in this case.

Somewhere I have a patch to remove some uses of ARRAY_SIZE in favor of
this approach...

thanks,
Tom