From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb: 'maint info sections' - handle the no executable case
Date: Mon, 08 Feb 2021 12:29:09 -0700 [thread overview]
Message-ID: <871rdqgxyy.fsf@tromey.com> (raw)
In-Reply-To: <e49d1445ad73db5bd9ccd4270c7c1d6e7c96b405.1612560410.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Fri, 5 Feb 2021 21:29:10 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Unfortunately, when I tried to use 'maint info sections' I saw
Andrew> nothing. The reason is that the loop over all object files is hidden
Andrew> behind a check that we have a main executable.
Andrew> This commit removes this check and merges together some duplicate
Andrew> code. I also (I think) made the output of this command cleaner.
Yeah, I agree.
Andrew> gdb/ChangeLog:
Andrew> * maint.c (print_bfd_section_info_maybe_relocated): Delete,
Andrew> functionality merged into...
Andrew> (maint_print_all_sections): ...this new function.
Andrew> (maintenance_info_sections): Make use of maint_print_all_sections,
Andrew> allow all objects to be printed even where there's no executable.
Andrew> gdb/testsuite/ChangeLog:
Andrew> * gdb.base/maint-info-sections.exp: Update expected output, and
Andrew> add additional tests.
Looks good.
Tom
next prev parent reply other threads:[~2021-02-08 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 21:29 [PATCH 0/3] Changes to 'maint info sections' Andrew Burgess
2021-02-05 21:29 ` [PATCH 1/3] gdb/testsuite: split 'maint info sections' tests to a new file Andrew Burgess
2021-02-08 19:28 ` Tom Tromey
2021-02-05 21:29 ` [PATCH 2/3] gdb: 'maint info sections' - handle the no executable case Andrew Burgess
2021-02-08 19:29 ` Tom Tromey [this message]
2021-02-05 21:29 ` [PATCH 3/3] gdb: change 'maint info section' to use command options Andrew Burgess
2021-02-06 7:16 ` Eli Zaretskii via Gdb-patches
2021-02-08 19:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rdqgxyy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox