From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] gdb/testsuite: split 'maint info sections' tests to a new file
Date: Mon, 08 Feb 2021 12:28:06 -0700 [thread overview]
Message-ID: <875z32gy0p.fsf@tromey.com> (raw)
In-Reply-To: <d4718b83886984c13c5c56ff4d6ddc4f90d2a5b5.1612560410.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Fri, 5 Feb 2021 21:29:09 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> The next couple of patches are going to add more tests for the 'maint
Andrew> info sections' command. Rather than try to jam these tests into the
Andrew> already quite long gdb.base/maint.c, this commit moves all of the
Andrew> tests for 'maint info sections' into a new file.
Andrew> I've updated the tests to make use of some newer testsuite constructs,
Andrew> like -wrap and $gdb_test_name for gdb_test_multiple, but otherwise the
Andrew> tests should not have changed with this commit.
Andrew> gdb/testsuite/ChangeLog:
Andrew> * gdb.base/maint-info-sections.exp: New file, content is moved
Andrew> from gdb.base/maint.exp and cleaned up to use latest testsuite
Andrew> techniques.
Andrew> * gdb.base/maint.exp: Tests moved out to
Andrew> gdb.base/maint-info-sections.exp.
Looks reasonable to me. Thank you.
Tom
next prev parent reply other threads:[~2021-02-08 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 21:29 [PATCH 0/3] Changes to 'maint info sections' Andrew Burgess
2021-02-05 21:29 ` [PATCH 1/3] gdb/testsuite: split 'maint info sections' tests to a new file Andrew Burgess
2021-02-08 19:28 ` Tom Tromey [this message]
2021-02-05 21:29 ` [PATCH 2/3] gdb: 'maint info sections' - handle the no executable case Andrew Burgess
2021-02-08 19:29 ` Tom Tromey
2021-02-05 21:29 ` [PATCH 3/3] gdb: change 'maint info section' to use command options Andrew Burgess
2021-02-06 7:16 ` Eli Zaretskii via Gdb-patches
2021-02-08 19:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z32gy0p.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox