Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 1/2] gdb/gdbarch: remove the predicate function for gdbarch_register_type
Date: Thu, 10 Mar 2022 10:06:26 -0700	[thread overview]
Message-ID: <87wnh1ohyl.fsf@tromey.com> (raw)
In-Reply-To: <e7bda06f4dffabacbbacf75ca771f1ea86de373e.1646918997.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 10 Mar 2022 13:31:23 +0000")

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> I don't believe that the gdbarch_register_type_p predicate is called
Andrew> anywhere in GDB, and the gdbarch_register_type function is called
Andrew> without checking the gdbarch_register_type_p predicate function
Andrew> everywhere it is used, for example in
Andrew> init_regcache_descr (regcache.c).

Andrew> My claim is that the gdbarch_register_type function is required for
Andrew> every architecture, and GDB will not work if this function is not
Andrew> supplied.

Andrew> And so, in this commit, I remove the 'predicate=True' from
Andrew> gdbarch-components.py for the 'register_type' field, and regenerate
Andrew> the gdbarch files.

Looks ok to me.

thanks,
Tom

  reply	other threads:[~2022-03-10 17:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 13:31 [PATCH 0/2] Some changes to the gdbarch*.py scripts Andrew Burgess via Gdb-patches
2022-03-10 13:31 ` [PATCH 1/2] gdb/gdbarch: remove the predicate function for gdbarch_register_type Andrew Burgess via Gdb-patches
2022-03-10 17:06   ` Tom Tromey [this message]
2022-03-10 13:31 ` [PATCH 2/2] gdb/gdbarch: compare some fields against 0 verify_gdbarch Andrew Burgess via Gdb-patches
2022-03-10 17:09   ` Tom Tromey
2022-03-14 14:10     ` Andrew Burgess via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnh1ohyl.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox