Re: [PATCH 1/2] gdb/gdbarch: remove the predicate function for gdbarch_register_type

Tom Tromey
2022-03-10T17:06:40Z

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> I don't believe that the gdbarch_register_type_p predicate is called
Andrew> anywhere in GDB, and the gdbarch_register_type function is called
Andrew> without checking the gdbarch_register_type_p predicate function
Andrew> everywhere it is used, for example in
Andrew> init_regcache_descr (regcache.c).

Andrew> My claim is that the gdbarch_register_type function is required for
Andrew> every architecture, and GDB will not work if this function is not
Andrew> supplied.

Andrew> And so, in this commit, I remove the 'predicate=True' from
Andrew> gdbarch-components.py for the 'register_type' field, and regenerate
Andrew> the gdbarch files.

Looks ok to me.

thanks,
Tom