Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 2/2] gdb/gdbarch: compare some fields against 0 verify_gdbarch
Date: Thu, 10 Mar 2022 10:09:42 -0700	[thread overview]
Message-ID: <87sfrpoht5.fsf@tromey.com> (raw)
In-Reply-To: <390f01c81a056b73b104ff580fcbea5c633acb9a.1646918997.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 10 Mar 2022 13:31:24 +0000")

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> The comment at the top of gdbarch-components.py tries to explain how
Andrew> the validation is done.  I didn't understand this comment completely,
Andrew> but, I think this final sentence:

I wrote it and now I don't really understand it either.
I guess I wasn't being as clear as I thought I was.

Andrew>  1. Handle the case where the 'invalid' field of a property is set to
Andrew>  True, this should perform a check for the field of gdbarch still
Andrew>  being set to 0, and

Andrew>  2. If the if/else series that generates verify_gdbarch doesn't handle
Andrew>  a property then we should raise an exception.  This means that if a
Andrew>  property is added which isn't handled, we should no longer silently
Andrew>  ignore it.

Looks good.

thanks,
Tom

  reply	other threads:[~2022-03-10 17:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 13:31 [PATCH 0/2] Some changes to the gdbarch*.py scripts Andrew Burgess via Gdb-patches
2022-03-10 13:31 ` [PATCH 1/2] gdb/gdbarch: remove the predicate function for gdbarch_register_type Andrew Burgess via Gdb-patches
2022-03-10 17:06   ` Tom Tromey
2022-03-10 13:31 ` [PATCH 2/2] gdb/gdbarch: compare some fields against 0 verify_gdbarch Andrew Burgess via Gdb-patches
2022-03-10 17:09   ` Tom Tromey [this message]
2022-03-14 14:10     ` Andrew Burgess via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfrpoht5.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox