From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IEqIIeQwKmKiGQAAWB0awg (envelope-from ) for ; Thu, 10 Mar 2022 12:09:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 87A531F3CA; Thu, 10 Mar 2022 12:09:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D3E581EA69 for ; Thu, 10 Mar 2022 12:09:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93509385840B for ; Thu, 10 Mar 2022 17:09:55 +0000 (GMT) Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 8C7C33858D39 for ; Thu, 10 Mar 2022 17:09:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C7C33858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id F139B1004BCCD for ; Thu, 10 Mar 2022 17:09:43 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id SMIJnCrOpY8ycSMIJnokUP; Thu, 10 Mar 2022 17:09:43 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ue6U9IeN c=1 sm=1 tr=0 ts=622a30d7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=BWhT4j3fM4U5p_3FU8cA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FKbWeGTUT0fVeLEup1cH9JZnvLDJcDxcCoO52m5vg24=; b=rZZoX6yaKJzyp2VBEwSP+UsYYd EHz11jfFjVS/CHVkhgxFXmbktfPVpJP8lLKiSbOybi3SlLrSlTK3D9qH9LCyHcJ8uwRNX/ykxF67j bwog3dd4XZk6MlPCTnFI/H24J; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37958 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSMII-003WLw-RS; Thu, 10 Mar 2022 10:09:42 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Subject: Re: [PATCH 2/2] gdb/gdbarch: compare some fields against 0 verify_gdbarch References: <390f01c81a056b73b104ff580fcbea5c633acb9a.1646918997.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 10 Mar 2022 10:09:42 -0700 In-Reply-To: <390f01c81a056b73b104ff580fcbea5c633acb9a.1646918997.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 10 Mar 2022 13:31:24 +0000") Message-ID: <87sfrpoht5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nSMII-003WLw-RS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37958 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> The comment at the top of gdbarch-components.py tries to explain how Andrew> the validation is done. I didn't understand this comment completely, Andrew> but, I think this final sentence: I wrote it and now I don't really understand it either. I guess I wasn't being as clear as I thought I was. Andrew> 1. Handle the case where the 'invalid' field of a property is set to Andrew> True, this should perform a check for the field of gdbarch still Andrew> being set to 0, and Andrew> 2. If the if/else series that generates verify_gdbarch doesn't handle Andrew> a property then we should raise an exception. This means that if a Andrew> property is added which isn't handled, we should no longer silently Andrew> ignore it. Looks good. thanks, Tom