Re: [PATCH] Fix tui new-layout -horizontal argument placement

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Petar" == Petar Popovic <pjoetri@gmail.com> writes:
>
> Petar> The optional argument `-horizontal` from `tui new-layout` is supposed
> Petar> to be checked directly after the command but instead it is checked
> Petar> after the layout name.
> Petar> This commit moves the check to the correct place.
>
> I wonder if this is really true or if it is just the "usage" line in the
> doc string that is wrong.
>
> I notice this form also isn't documented.
>
> I tend to think it is better to fix the docs and not change the code
> here, because overall I think the intent was for window layouts to have
> more or less the same "shape", that is
>
> tui new-layout name -horizontal ...
>
> and
>
> tui new-layout name {-horizontal ...}

Also, this has been around for a while, so making this change would
break existing users code, which we usually try to avoid.

I agree updating the docs would be better.

Thanks,
Andrew