From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hSRXK+dcMWlaqBgAWB0awg (envelope-from ) for ; Thu, 04 Dec 2025 05:05:27 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Wk9/aWIN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A38F31E0B3; Thu, 04 Dec 2025 05:05:27 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0BEF11E08D for ; Thu, 04 Dec 2025 05:05:27 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 773ED4B1A36D for ; Thu, 4 Dec 2025 10:05:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 773ED4B1A36D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Wk9/aWIN Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B0E9E4BBCDB0 for ; Thu, 4 Dec 2025 10:05:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0E9E4BBCDB0 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B0E9E4BBCDB0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764842701; cv=none; b=i3wGth+NF+Q9gAsVmcwUFZIhVZZNMP+JpD6M6zrHouICxSGC9jpWI7Lh07YUcIAibud/jXr5JTyeLxAWnXMb9AE8Sm5IL9xK5OpxImoAvoaGIs+L/Yg4oUS2CbZvnbuP1OH1VwZWDbDhO8pPqVIZa/p8RlOzHBKGxXv1jqG/4mI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764842701; c=relaxed/simple; bh=ZbHkIuxpeBKB8s9RgslPM2T7YDPq4RUkEEQjVxcgyd4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KF4mspmPNPAjSnjHGqEDR1kXHmLHA+Y22gjuFEQrhwrAJGvpljtPNH7uIx4yFjzP1Nd2VRm8oNFEtkvkcCjcdklia2l9sbeX+ea+rXcFLIsXjOMB+3pAu9C03JlI7WPgTug6uMsHwkL5xiXuWr0k1UUNI5QhoY8I0Ox9WmJa0EA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0E9E4BBCDB0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764842701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZbHkIuxpeBKB8s9RgslPM2T7YDPq4RUkEEQjVxcgyd4=; b=Wk9/aWINk4/Qv/l/GC1HY992g3awLZzC4zDGcSFCVsNWxepIE/6sKJWFkLZFJxF0bQ3JTT ihSB+5neMJkSlVuir7pPVLq5hm90helU5KeCcf5Fw7IMpvOaz/qCtFUL3b/mhDp4iiIBDB 8ZuC2OjA2xDF+F19UiDMHa0E8jUsDrI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-ufFrfm6BODqKkLacXjhRoA-1; Thu, 04 Dec 2025 05:04:58 -0500 X-MC-Unique: ufFrfm6BODqKkLacXjhRoA-1 X-Mimecast-MFC-AGG-ID: ufFrfm6BODqKkLacXjhRoA_1764842697 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-42e2d02b528so473783f8f.0 for ; Thu, 04 Dec 2025 02:04:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764842697; x=1765447497; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZbHkIuxpeBKB8s9RgslPM2T7YDPq4RUkEEQjVxcgyd4=; b=NyRRLq3jHVtD2HEuuKqQ06BakQps65XUi1NcuM8NEQ0Fhs49rMwyc5mIWWgvEr6PJl mfUE9LYR24QfIcIkTi3wDXyyDZDlovdwGPWd2S2P4N+dwR74M2TFB8KtU7RmHMSXfsPi oytkMaL2rPXxQ+/87uBdYnADkamgSEUB/zI50tLzlNFn63RG+cnGx+80sZAZOaf0osyG cy3lUt8UWLxEHMpGUOAgy+7Z5G26ugn4fnXYxAZlQWgVhiUtjSJZpIDyXIsX9qyWmp9s 8aoZjGkWMgLPgzn9CBYr/9+ciAUiB30bZrrhMj7Y/PFU3jgCwruycB3paJCYxQhbD4NC fnTQ== X-Gm-Message-State: AOJu0YwpMlVhCbLEAtoEC0OTgsuwaYz3huN315Zm0aoIFF19wsvGUJSY r81Eowc7PRLd+EMU7PAJXUnqLIkTRPLo7Z9EdMMAkpHfTBs1vWiLgsVTIjWh/22wXydAhc3bBdy sgPhtFVXRJa/CCjXF1tQkq3gR2GdBjOrK+KWCEPKC6Dou2T+wQNgxtQk97HI1y+o= X-Gm-Gg: ASbGncsOEnVvcKvEb9bAcUxG+8aP4ev7t9OU6wGRh6QLxVnWmP6OpKertFzGyYGUATm vKilI9BnC7U78CVdhEY3UQv4CZyPgEzGFgGe1Y28ULeAANER6vh5YYD5D99NRGxlWj32FEFa8zb fGfyU+enCzCmwoJW1Rma+ByYR0yB6ZPdtRllfJhJv2R6as6V45KDomzWq7L+HUQRDrDslR7hMvQ 6G0xsofPCf9zDDUHykz9PwaI9i+2dvIqNfDLx+RI8QOqnSrlLNd2BbNNlMgtS86L1ttHUWz15Vq tfIXTEh/HVUvpkob9Jx2Vw3Gm0XO7cndqz/wuAoAEEDhvrJ7MYbiw1RaobOBgNt04pq6ludSZyX X0JCs X-Received: by 2002:a05:6000:2502:b0:427:914:7468 with SMTP id ffacd0b85a97d-42f7317d51dmr5491368f8f.15.1764842696809; Thu, 04 Dec 2025 02:04:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhoWrfTuIOk9wYIyHUFYLA30qTcChP3R0zivWba+0Wo6ppR0ShTglnvlq0Ap6mLydnYdHzxw== X-Received: by 2002:a05:6000:2502:b0:427:914:7468 with SMTP id ffacd0b85a97d-42f7317d51dmr5491338f8f.15.1764842696383; Thu, 04 Dec 2025 02:04:56 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbfee50sm2362613f8f.14.2025.12.04.02.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 02:04:55 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Petar Popovic Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix tui new-layout -horizontal argument placement In-Reply-To: <87jyz36vx1.fsf@tromey.com> References: <87jyz36vx1.fsf@tromey.com> Date: Thu, 04 Dec 2025 10:04:55 +0000 Message-ID: <87wm32r29k.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: owJOpt9iQUltNvGoShseX1t2zAFNaE4eR0sAd2HefPs_1764842697 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Petar" == Petar Popovic writes: > > Petar> The optional argument `-horizontal` from `tui new-layout` is supposed > Petar> to be checked directly after the command but instead it is checked > Petar> after the layout name. > Petar> This commit moves the check to the correct place. > > I wonder if this is really true or if it is just the "usage" line in the > doc string that is wrong. > > I notice this form also isn't documented. > > I tend to think it is better to fix the docs and not change the code > here, because overall I think the intent was for window layouts to have > more or less the same "shape", that is > > tui new-layout name -horizontal ... > > and > > tui new-layout name {-horizontal ...} Also, this has been around for a while, so making this change would break existing users code, which we usually try to avoid. I agree updating the docs would be better. Thanks, Andrew