Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Petar Popovic <pjoetri@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix tui new-layout -horizontal argument placement
Date: Wed, 03 Dec 2025 15:30:02 -0700	[thread overview]
Message-ID: <87jyz36vx1.fsf@tromey.com> (raw)
In-Reply-To: <CAD1v46vK5QXoNudAep5dMKSEAmB6nRZTkv9ptATvqASX86fz1w@mail.gmail.com> (Petar Popovic's message of "Sat, 29 Nov 2025 18:40:01 +0100")

>>>>> "Petar" == Petar Popovic <pjoetri@gmail.com> writes:

Petar> The optional argument `-horizontal` from `tui new-layout` is supposed
Petar> to be checked directly after the command but instead it is checked
Petar> after the layout name.
Petar> This commit moves the check to the correct place.

I wonder if this is really true or if it is just the "usage" line in the
doc string that is wrong.

I notice this form also isn't documented.

I tend to think it is better to fix the docs and not change the code
here, because overall I think the intent was for window layouts to have
more or less the same "shape", that is

tui new-layout name -horizontal ...

and

tui new-layout name {-horizontal ...}

Tom

  reply	other threads:[~2025-12-03 22:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-29 17:40 Petar Popovic
2025-12-03 22:30 ` Tom Tromey [this message]
2025-12-04 10:04   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jyz36vx1.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pjoetri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox