From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rVUIJAm6MGnw5xYAWB0awg (envelope-from ) for ; Wed, 03 Dec 2025 17:30:33 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jGJMJpur; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 82FF71E0B3; Wed, 03 Dec 2025 17:30:33 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DA8691E048 for ; Wed, 03 Dec 2025 17:30:32 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4DEE74BBC081 for ; Wed, 3 Dec 2025 22:30:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4DEE74BBC081 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jGJMJpur Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 7C70C4B920B9 for ; Wed, 3 Dec 2025 22:30:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C70C4B920B9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C70C4B920B9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764801005; cv=none; b=Ztf1sTiFp/YwFiPOn36Guy1Wujb6sID58EiOV6/SRnTKR4Jc5e1/HOqG+LnfmcWjL744UVnpsrKS+IaT+af6nAtq3z+5xbsFe8QSfPLx4f6MgrepyqJayVymYdXYDeh+/e9GsJah4XTRRhq0WAZKQpc1KIQ+pS5NCby5EzQFmT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764801005; c=relaxed/simple; bh=XD4/YOwdU081nJyaacJnCBABOvX0JpjEQU0VuZ5+xFY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lfZ2iKNO65Z83Ii6C5Pj18+hgnhBtKhePrgS9mMo32JhTfbMDH47uBzFafkIliq9CjMzRi46zuMKIZ6U5BkBsnKZtUltu1fdlXbbEUFw6uQTz5pmjtwEtHAMnZg8NTp+iY8DsuF5aV+XRZA3JxFQTXbeE+YNZmG4/8acADCLqiI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C70C4B920B9 Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id QutevvXo0VCBNQvMKv6fHo; Wed, 03 Dec 2025 22:30:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QvMJvS8ppK8vzQvMKvjTwn; Wed, 03 Dec 2025 22:30:04 +0000 X-Authority-Analysis: v=2.4 cv=cJDgskeN c=1 sm=1 tr=0 ts=6930b9ec a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=Zl7fVAB2s9ge0KmBOrgA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XD4/YOwdU081nJyaacJnCBABOvX0JpjEQU0VuZ5+xFY=; b=jGJMJpur/c2bq6WQv+HdmULmZ2 mMOYb/FJvbbsEFvL2AhB13fZHxdLZ5q6+OvHo6UqqSanTB908q5uBSXeWB6I6x51gRLj1YFuh4d1F wfKIMX9oHvcXsW1GJ3tp9JX0i; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:35872 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vQvMJ-000000027q6-2TbS; Wed, 03 Dec 2025 15:30:03 -0700 From: Tom Tromey To: Petar Popovic Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix tui new-layout -horizontal argument placement In-Reply-To: (Petar Popovic's message of "Sat, 29 Nov 2025 18:40:01 +0100") References: X-Attribution: Tom Date: Wed, 03 Dec 2025 15:30:02 -0700 Message-ID: <87jyz36vx1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vQvMJ-000000027q6-2TbS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:35872 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDmScG/ByxfHdjnuJo1QFlMRaTIqyI9ddZ6DG+2VH+kZumQQ0wJW38Ibmig8zW4e6muDhMBV1fnaJNXPi3rrnNtRY2i01cw2idBMG0S7tqFlyCsXC1y8 Gpy4ZW6G/K6zPhDZC26/5jq9IfxYFzLyN1fwoc2PHvrB/h/doQpoT/D0UedLqXmnFTFpNILD8fNQzchT4FRbW6JpRxTrZJawhdw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Petar" == Petar Popovic writes: Petar> The optional argument `-horizontal` from `tui new-layout` is supposed Petar> to be checked directly after the command but instead it is checked Petar> after the layout name. Petar> This commit moves the check to the correct place. I wonder if this is really true or if it is just the "usage" line in the doc string that is wrong. I notice this form also isn't documented. I tend to think it is better to fix the docs and not change the code here, because overall I think the intent was for window layouts to have more or less the same "shape", that is tui new-layout name -horizontal ... and tui new-layout name {-horizontal ...} Tom