From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header.
Date: Tue, 18 Dec 2012 16:27:00 -0000 [thread overview]
Message-ID: <87vcbzs4vj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20105.7837847204$1355819774@news.gmane.org> (Pierre Muller's message of "Tue, 18 Dec 2012 09:35:39 +0100")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> This is both a RFA
Pierre> and a question about:
Pierre> should this be considered as an obvious fix?
Pierre> i.e. shouldn't all functions declared in headers
Pierre> have the extern modifier?
Pierre> Is this mandatory?
It isn't mandatory right now, gdb does it both ways. I don't really
care about this issue so I just tend to use whatever is used nearby. I
think Joel at least has argued for making this part of the gdb style.
Tom
next parent reply other threads:[~2012-12-18 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20105.7837847204$1355819774@news.gmane.org>
2012-12-18 16:27 ` Tom Tromey [this message]
2012-12-18 8:35 Pierre Muller
2012-12-18 8:47 ` Jan Kratochvil
2012-12-22 18:57 ` Pierre Muller
2012-12-18 8:54 ` Yao Qi
2012-12-18 9:00 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcbzs4vj.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox