From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97165-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32420 invoked by alias); 18 Dec 2012 16:27:38 -0000
Received: (qmail 32352 invoked by uid 22791); 18 Dec 2012 16:27:34 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 16:27:01 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIGQwrL014576	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 18 Dec 2012 11:26:59 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBIGQuiW019838	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 18 Dec 2012 11:26:57 -0500
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header.
References: <20105.7837847204$1355819774@news.gmane.org>
Date: Tue, 18 Dec 2012 16:27:00 -0000
In-Reply-To: <20105.7837847204$1355819774@news.gmane.org> (Pierre Muller's	message of "Tue, 18 Dec 2012 09:35:39 +0100")
Message-ID: <87vcbzs4vj.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00638.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>    This is both a RFA
Pierre>  and a question about:
Pierre>   should this be considered as an obvious fix?
  
Pierre>   i.e. shouldn't all functions declared in headers
Pierre> have the extern modifier?
Pierre>   Is this mandatory?

It isn't mandatory right now, gdb does it both ways.  I don't really
care about this issue so I just tend to use whatever is used nearby.  I
think Joel at least has argued for making this part of the gdb style.

Tom