From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Jan Kratochvil'" <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header.
Date: Sat, 22 Dec 2012 18:57:00 -0000 [thread overview]
Message-ID: <003001cde076$2d4d8430$87e88c90$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20121218084715.GC8054@host2.jankratochvil.net>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Jan Kratochvil
> Envoyé : mardi 18 décembre 2012 09:47
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in
header.
>
> On Tue, 18 Dec 2012 09:35:39 +0100, Pierre Muller wrote:
> > i.e. shouldn't all functions declared in headers
> > have the extern modifier?
> > Is this mandatory?
> > It doesn't see to change anything in practice, but to me,
> > it seems like good practice...
>
> I agree, it does not change anything. I agree it is probably GNU Coding
> Standards do not talk about it so it could be added to
> gdb/doc/gdbint.texinfo
> "Coding Standards".
>
> I am OK with such kind of changes as obvious ones after updating
> gdbint.texinfo.
>
OK, thus after change to gdbint.texinfo,
I committed this patch as obvious in:
http://sourceware.org/ml/gdb-cvs/2012-12/msg00175.html
I modified the submitted patch to correctly align the parameters of
the following lines, as you suggested.
Thanks Jan,
Pierre Muller
next prev parent reply other threads:[~2012-12-22 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 8:35 Pierre Muller
2012-12-18 8:47 ` Jan Kratochvil
2012-12-22 18:57 ` Pierre Muller [this message]
2012-12-18 8:54 ` Yao Qi
2012-12-18 9:00 ` Jan Kratochvil
[not found] <20105.7837847204$1355819774@news.gmane.org>
2012-12-18 16:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003001cde076$2d4d8430$87e88c90$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox