From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22795 invoked by alias); 22 Dec 2012 18:57:37 -0000 Received: (qmail 22787 invoked by uid 22791); 22 Dec 2012 18:57:37 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 22 Dec 2012 18:57:31 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBMIvNEa034627 ; Sat, 22 Dec 2012 19:57:23 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBMIvMso003451 ; Sat, 22 Dec 2012 19:57:22 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBMIvLq9027666 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Sat, 22 Dec 2012 19:57:22 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Jan Kratochvil'" Cc: References: <001801cddcfa$a93cef10$fbb6cd30$@muller@ics-cnrs.unistra.fr> <20121218084715.GC8054@host2.jankratochvil.net> In-Reply-To: <20121218084715.GC8054@host2.jankratochvil.net> Subject: RE: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header. Date: Sat, 22 Dec 2012 18:57:00 -0000 Message-ID: <003001cde076$2d4d8430$87e88c90$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00783.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Jan Kratochvil > Envoy=E9=A0: mardi 18 d=E9cembre 2012 09:47 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header. >=20 > On Tue, 18 Dec 2012 09:35:39 +0100, Pierre Muller wrote: > > i.e. shouldn't all functions declared in headers > > have the extern modifier? > > Is this mandatory? > > It doesn't see to change anything in practice, but to me, > > it seems like good practice... >=20 > I agree, it does not change anything. I agree it is probably GNU Coding > Standards do not talk about it so it could be added to > gdb/doc/gdbint.texinfo > "Coding Standards". >=20 > I am OK with such kind of changes as obvious ones after updating > gdbint.texinfo. >=20 OK, thus after change to gdbint.texinfo, I committed this patch as obvious in: http://sourceware.org/ml/gdb-cvs/2012-12/msg00175.html I modified the submitted patch to correctly align the parameters of=20 the following lines, as you suggested. Thanks Jan, Pierre Muller