From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Keith Seitz <keiths@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA] Constify find_condition_and_thread
Date: Fri, 01 Mar 2013 19:33:00 -0000 [thread overview]
Message-ID: <87vc9aud7p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5130F9BB.6020002@redhat.com> (Pedro Alves's message of "Fri, 01 Mar 2013 18:55:55 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> An alternative would be to perhaps make the interface of
Pedro> parse_exp_1 similar to strtol -- split input and output
Pedro> pointers, with the explicit guarantee that the output pointer
Pedro> points somewhere within the input string. Is it really that
Pedro> messy? There doesn't seem to be many parse_exp_1 callers.
I think the problem is that the parsers probably do modify the input
string. So, you couldn't pass in a readonly string.
E.g., see c-exp.y:parse_number. It modifies the string, but then
modifies it back.
Tom
next prev parent reply other threads:[~2013-03-01 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 18:18 Keith Seitz
2013-03-01 18:40 ` Eli Zaretskii
2013-03-01 18:56 ` Pedro Alves
2013-03-01 19:33 ` Tom Tromey [this message]
2013-03-02 7:30 ` Eli Zaretskii
2013-03-01 18:56 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc9aud7p.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox