Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Constify find_condition_and_thread
Date: Fri, 01 Mar 2013 18:40:00 -0000	[thread overview]
Message-ID: <83ppzjufp5.fsf@gnu.org> (raw)
In-Reply-To: <5130F0FD.2040203@redhat.com>

> Date: Fri, 01 Mar 2013 10:18:37 -0800
> From: Keith Seitz <keiths@redhat.com>
> 
> -	  expr = parse_exp_1 (&tok, pc, block_for_pc (pc), 0);
> +	  orig = copy = xstrdup (tok);
> +	  cleanup = make_cleanup (xfree, orig);
> +	  expr = parse_exp_1 (&copy, pc, block_for_pc (pc), 0);
>  	  xfree (expr);
> +	  tok += copy - orig;
> +	  do_cleanups (cleanup);

If we really need this kind of dance, just to avoid explicit casts to
'char *', there should be a comment explaining why we do this.

Thanks.


  reply	other threads:[~2013-03-01 18:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 18:18 Keith Seitz
2013-03-01 18:40 ` Eli Zaretskii [this message]
2013-03-01 18:56   ` Pedro Alves
2013-03-01 19:33     ` Tom Tromey
2013-03-02  7:30       ` Eli Zaretskii
2013-03-01 18:56 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ppzjufp5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox