From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20403 invoked by alias); 1 Mar 2013 19:33:54 -0000 Received: (qmail 20394 invoked by uid 22791); 1 Mar 2013 19:33:53 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 19:33:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r21JXle3025591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Mar 2013 14:33:48 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r21JXkKK025245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 1 Mar 2013 14:33:47 -0500 From: Tom Tromey To: Pedro Alves Cc: Eli Zaretskii , Keith Seitz , gdb-patches@sourceware.org Subject: Re: [RFA] Constify find_condition_and_thread References: <5130F0FD.2040203@redhat.com> <83ppzjufp5.fsf@gnu.org> <5130F9BB.6020002@redhat.com> Date: Fri, 01 Mar 2013 19:33:00 -0000 In-Reply-To: <5130F9BB.6020002@redhat.com> (Pedro Alves's message of "Fri, 01 Mar 2013 18:55:55 +0000") Message-ID: <87vc9aud7p.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00042.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> An alternative would be to perhaps make the interface of Pedro> parse_exp_1 similar to strtol -- split input and output Pedro> pointers, with the explicit guarantee that the output pointer Pedro> points somewhere within the input string. Is it really that Pedro> messy? There doesn't seem to be many parse_exp_1 callers. I think the problem is that the parsers probably do modify the input string. So, you couldn't pass in a readonly string. E.g., see c-exp.y:parse_number. It modifies the string, but then modifies it back. Tom