From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>,
Joel Brobecker <brobecker@gnat.com>
Subject: Re: [PATCH][gdb/testsuite] Fix ada tests with -fPIE/-pie
Date: Wed, 07 Aug 2019 14:18:00 -0000 [thread overview]
Message-ID: <87v9v96oul.fsf@tromey.com> (raw)
In-Reply-To: <20190807110713.GA23000@delia> (Tom de Vries's message of "Wed, 7 Aug 2019 13:07:14 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> When running the gdb testsuite with target board unix/-fPIE/-pie, the
Tom> resulting ada executables are not PIE executables, because gnatmake doesn't
Tom> recognize -pie, and consequently doesn't pass it to gnatlink.
Tom> Fix this by replacing "-pie" with "-largs -pie -margs" for ada test-cases in
Tom> gdb_default_target_compile, and doing the same for -no-pie.
I think this is a good idea overall.
However, is gdb_default_target_compile still used? And if so, by what
path? My understanding is that with a "new enough" dejagnu, it won't be
used -- so some users might still see the old behavior.
Basically gdb_default_target_compile is all a big monkeypatching hack
and it would be way better to have some kind of more principled approach
upstream. I don't know what that would look like. And of course to get
there we'd probably need even more monkeypatching.
Tom
next prev parent reply other threads:[~2019-08-07 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 11:07 Tom de Vries
2019-08-07 14:18 ` Tom Tromey [this message]
2019-08-07 15:27 ` Tom de Vries
2019-08-08 10:15 ` Tom de Vries
2019-08-21 7:15 ` [PING][PATCH][gdb/testsuite] " Tom de Vries
2019-08-28 7:18 ` [PING^2][PATCH][gdb/testsuite] " Tom de Vries
2019-09-04 8:17 ` [PING^3][PATCH][gdb/testsuite] " Tom de Vries
2019-09-13 19:47 ` [PING^4][PATCH][gdb/testsuite] " Tom de Vries
2019-10-09 14:49 ` [PING][PATCH][gdb/testsuite] " Tom Tromey
2019-10-10 14:03 ` [gdb/testsuite] Compile ada with -lgnarl_pic and -lgnat_pic if required Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9v96oul.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox