From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85803 invoked by alias); 7 Aug 2019 14:18:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85748 invoked by uid 89); 7 Aug 2019 14:18:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=overall X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.192.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 14:18:30 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id D049E400C34E4 for ; Wed, 7 Aug 2019 08:43:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vMlnhPIeA2qH7vMlnhPyjf; Wed, 07 Aug 2019 09:18:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MBxO5pJVWDfFUlX3XCMZbe/KPH98fW1k8qewSBnLhEA=; b=LWxIs6U2KyU0Qp1gNKLcJNi3hp KAfGpHA25ha/zbh19KW2inc8n8+0Mnn4zDbn7efrfjxoT097VayI52lUr9DWrXt/B4a3JgKtGem9p 1cb1BL6FoJoVrq893XJ93urrl; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:56860 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hvMln-003eRa-5L; Wed, 07 Aug 2019 09:18:27 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey , Joel Brobecker Subject: Re: [PATCH][gdb/testsuite] Fix ada tests with -fPIE/-pie References: <20190807110713.GA23000@delia> Date: Wed, 07 Aug 2019 14:18:00 -0000 In-Reply-To: <20190807110713.GA23000@delia> (Tom de Vries's message of "Wed, 7 Aug 2019 13:07:14 +0200") Message-ID: <87v9v96oul.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00174.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> When running the gdb testsuite with target board unix/-fPIE/-pie, the Tom> resulting ada executables are not PIE executables, because gnatmake doesn't Tom> recognize -pie, and consequently doesn't pass it to gnatlink. Tom> Fix this by replacing "-pie" with "-largs -pie -margs" for ada test-cases in Tom> gdb_default_target_compile, and doing the same for -no-pie. I think this is a good idea overall. However, is gdb_default_target_compile still used? And if so, by what path? My understanding is that with a "new enough" dejagnu, it won't be used -- so some users might still see the old behavior. Basically gdb_default_target_compile is all a big monkeypatching hack and it would be way better to have some kind of more principled approach upstream. I don't know what that would look like. And of course to get there we'd probably need even more monkeypatching. Tom