Re: [PATCH] gdb/m2: add builtin procedure function ADR

[Tom Tromey <tom@tromey.com>]

>>>>> "Gaius" == Gaius Mulley <gaiusmod2@gmail.com> writes:

Hi.  Thanks for the patch.

Gaius> This patch introduces the procedure function ADR to the expression
Gaius> handling parser for the Modula-2 language interface.
Gaius> The procedure takes a parameter and returns the address of the
Gaius> parameter supplied.

Gaius> Tested on x86_64-linux.

Gaius> ChangeLog:

Gaius> 	* gdb/m2-exp.y (%token): Add ADR.
Gaius> 	(exp): New rule for ADR.
Gaius> 	(keytab): New entry for ADR.
Gaius> 	* gdb/doc/gdb.texinfo (Built-in Functions and Procedures):
Gaius> 	Add description for procedure function ADR.

gdb doesn't use ChangeLog entries any more so you can remove this part
of the commit message.

The code parts of this look good to me, but committing will have to wait
for doc review.

I think a test case -- even just a single line in an existing test --
would probably be good to have.

thanks,
Tom