From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pnE4Cyz2/2ZWHgEAWB0awg (envelope-from ) for ; Fri, 04 Oct 2024 10:05:32 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Dh9ox+gV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0DD591E355; Fri, 4 Oct 2024 10:05:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F5871E05C for ; Fri, 4 Oct 2024 10:05:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ADDAE3844042 for ; Fri, 4 Oct 2024 14:05:30 +0000 (GMT) Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id D306C386D620 for ; Fri, 4 Oct 2024 14:05:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D306C386D620 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D306C386D620 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728050710; cv=none; b=Skcqj7dg0A7u5Cw+D6AP0KKkm/ymCc87+Ha/L83JBaYQoofbN4b3cYAiona064mdp8wFE513UD8/2HOzEG9A4uH6Cq0EvqsnZK5Y4cNYeni2PwEXNAVbVkcP9ltRO0Ktf01bk/mRd+i+2iN0txPqzRQK0QjnMzm2ZgiZAb2I44s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728050710; c=relaxed/simple; bh=UucAQnr+K2p/2py97ZXQS2B1QDhtlm3NgYCpAAtKuXg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hV4Wu6i/1PL0h7hhVFmI3cOfaQZIWUYwdvJB+jGjq2pMzq2Sv/mgVX6DHAYGHVGgRV7m8mDD00bZSLz3HfD95HhCtIcTCKaH2QLfXT3QDas8feT2bvRzTveytHu2tQ4jlbJKsfmUMFRA7npdGZush/VLtQpLVeDHdXFe546c5rM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTPS id whXFsGbgynNFGwivasNEL6; Fri, 04 Oct 2024 14:05:06 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wivZsHF8CxS8LwivZsotk6; Fri, 04 Oct 2024 14:05:05 +0000 X-Authority-Analysis: v=2.4 cv=Wa4KaVhX c=1 sm=1 tr=0 ts=66fff611 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=DAUX931o1VcA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=12_IOjipjFOqjPOwH14A:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qESvXCxx97p6un8HTIOzXqTHa0Vn9qWoKADiSK2Wrm0=; b=Dh9ox+gV9DjteuN3sTY2AV+S/Q nAIHdc36aPTu15G1HXhZ+m/K5opV+azIlnPJEs1UDDx5XUSWgt6By8ushXeEyk19N22dxn02+90pN zRFYeJFeG4JAHMNkyowJL6Qhh; Received: from 97-122-122-36.hlrn.qwest.net ([97.122.122.36]:39010 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1swivZ-002ZG1-0A; Fri, 04 Oct 2024 08:05:05 -0600 From: Tom Tromey To: Gaius Mulley Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/m2: add builtin procedure function ADR In-Reply-To: <875xq8x90o.fsf@localhost> (Gaius Mulley's message of "Fri, 04 Oct 2024 15:00:55 +0100") References: <875xq8x90o.fsf@localhost> X-Attribution: Tom Date: Fri, 04 Oct 2024 08:05:04 -0600 Message-ID: <87v7y8ge0f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.36 X-Source-L: No X-Exim-ID: 1swivZ-002ZG1-0A X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-36.hlrn.qwest.net (murgatroyd) [97.122.122.36]:39010 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGH1vvaP3bFBjWjBoAP4gcsaSuPFovPDvTE1B6arB3Oww2GuwviJ0fhLiYH8uNBHaUIx7kLCgTBSD2KhGZ35TiGILkq+5nZyLU2NKBd/uiVJP1PO47PU 01CLDDST8vithdi+1UAdFRvro3FjniF07mKhky4JHLD70Dopb97CMaSLA92OkLwCp+FIeK6jOL3dbJid9HVQB5mZhvYZMstyJSw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Gaius" == Gaius Mulley writes: Hi. Thanks for the patch. Gaius> This patch introduces the procedure function ADR to the expression Gaius> handling parser for the Modula-2 language interface. Gaius> The procedure takes a parameter and returns the address of the Gaius> parameter supplied. Gaius> Tested on x86_64-linux. Gaius> ChangeLog: Gaius> * gdb/m2-exp.y (%token): Add ADR. Gaius> (exp): New rule for ADR. Gaius> (keytab): New entry for ADR. Gaius> * gdb/doc/gdb.texinfo (Built-in Functions and Procedures): Gaius> Add description for procedure function ADR. gdb doesn't use ChangeLog entries any more so you can remove this part of the commit message. The code parts of this look good to me, but committing will have to wait for doc review. I think a test case -- even just a single line in an existing test -- would probably be good to have. thanks, Tom