Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gaius Mulley <gaiusmod2@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/m2: add builtin procedure function ADR
Date: Fri, 04 Oct 2024 19:52:53 +0100	[thread overview]
Message-ID: <87h69raeey.fsf@localhost> (raw)
In-Reply-To: <87msjjhh0f.fsf@tromey.com> (Tom Tromey's message of "Fri, 04 Oct 2024 12:14:56 -0600")

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Gaius" == Gaius Mulley <gaiusmod2@gmail.com> writes:
>
> Gaius> Many thanks for the review, here is v2 with a testcase.  In v2 the only
> Gaius> change is the new file gdb/testsuite/gdb.modula2/builtin-procedure-adr.exp.
>
> Looks good to me.  Thank you.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom

Many thanks!

  reply	other threads:[~2024-10-04 18:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 14:00 [PATCH] " Gaius Mulley
2024-10-04 14:05 ` Tom Tromey
2024-10-04 15:21   ` [PATCH v2] " Gaius Mulley
2024-10-04 18:14     ` Tom Tromey
2024-10-04 18:52       ` Gaius Mulley [this message]
2024-10-04 14:25 ` [PATCH] " Eli Zaretskii
2024-10-04 15:45   ` Gaius Mulley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h69raeey.fsf@localhost \
    --to=gaiusmod2@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox