From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lNiGHqI5AGfdXgEAWB0awg (envelope-from ) for ; Fri, 04 Oct 2024 14:53:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=aBUSkjVS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 683141E355; Fri, 4 Oct 2024 14:53:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0A57D1E05C for ; Fri, 4 Oct 2024 14:53:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 975EF385EC11 for ; Fri, 4 Oct 2024 18:53:21 +0000 (GMT) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 90391385E44D for ; Fri, 4 Oct 2024 18:52:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90391385E44D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 90391385E44D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728067978; cv=none; b=J5cMhtqxBSQpRpU8K062G6fI9kpaP/Ks3/zD2EXbR6XlSxEFA9crfjzeLri6JfbdtCWokntSog1SmC1QMomG3CzXdfiGvJjb6QjT37amxLkOINI8e8J/KkoS+951f+zyDKEmvmBzftXIpc35J05xW5PW/jWtSjVEkiRtKLIb0Hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728067978; c=relaxed/simple; bh=rkuOo/zGzkbSH9ew529zZNMIwX5TXO6nkeBLDuLnXGI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Owl4ivVPsBr8pGrSF47/l0UQtSsToXftXqwnB4DGeqY3gUorsnhL+VHiz3c10rRahvwSlfWQJ8aoSGPHevqYDAthv7JSVY3PaQdidQc/2j1Pda3MF58pmnhgNRGPdAnAjxdr7V8h/T2gngrd6/mVhoLZ228OyBpnP2tuCzfQpgk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a8d0d82e76aso380346266b.3 for ; Fri, 04 Oct 2024 11:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728067975; x=1728672775; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PKzLjfs4FDyUpc9dar/nOnbNfOBJ65bpBx/dV3YaRJ8=; b=aBUSkjVS4SmHzIHUJgRtA0uyv2JMg2IO1hSQwKlSVq0soEKp80+/0b1jMvJ8O0MSCf tuFix6rtHarAH/EP6iqYQYVWs6IjGQat7PdbH27+iEUP0ZEEyBpOyqH51fY8zeszBgMx eZkOc3qdFcvMxAX1s6++RlXhwfSZHOpTGpGBlSsPWtR/QFhfSFGOee27F3H/ThnbEcgJ Rnv7tLzh6dgkbkTJGOMcGNJpFafe9FL/n60gJMA0F9tO2/Sy6qSR+p1833xnS6HpdjpT UdWp73X//uZeBgpiGEdC3KXTjdy4K2TzcQkuZVRpb36h4RNUDLwh7mzMsKDEIGunrMrJ FLkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728067975; x=1728672775; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PKzLjfs4FDyUpc9dar/nOnbNfOBJ65bpBx/dV3YaRJ8=; b=MfvZhF2p8vNDuE03rmOT2/ImDB6PWcck4U9IUI0VBuvrNJSlQBJQsCdJFP38VyLPS8 Y4z3G8AHx3zizx5pQKKCp9t2ebEVvCxPDZFaqLRgIBLghoLwNLnxm6deukUkRXdLAYJn t3AKBGdRBQseAhjhQHdw3exLGewN7aS0w8U39QPIqC3Qn9xtWKYg73T0Ak/ke4W4Cah3 oJhd0sPrSe1cjIyU/Scta3/Fs0HeD1ArWEaRTaDKESAgFbtIGDPEKSt3PmknzzHVkdze p8wMCtS+/sFgQdP7CKsWVgGjsF2Pj2MyZwWBsDixnY95MUSoJCm5+aF1D6aQrXEOaGNk R+rw== X-Gm-Message-State: AOJu0Yzs4RMH1MBMRsJhehWfcDY+HMj6FvoiTWowhGal4dDb7Y9hilB9 PD6X+25bWnzZqz75k8Vzl8mKjVhG8gBMbOA5QqTb7ZqqwlvhvLc6v9uFyg== X-Google-Smtp-Source: AGHT+IEopY04+rKJ7FHPgRm0BljGAonoWR8XxR+o4O4pAWVYAhTlAk1EWBRozIZBlqb4+02mlct80g== X-Received: by 2002:a17:907:9726:b0:a86:a41c:29b with SMTP id a640c23a62f3a-a991bd05711mr322930566b.8.1728067974822; Fri, 04 Oct 2024 11:52:54 -0700 (PDT) Received: from lancelot (dsl89-213-70-133.as15444.net. [89.213.70.133]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a992e7b41e8sm28394566b.163.2024.10.04.11.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 11:52:54 -0700 (PDT) Received: from gaius by lancelot with local (Exim 4.96) (envelope-from ) id 1swnQ5-00Cb1u-20; Fri, 04 Oct 2024 19:52:53 +0100 From: Gaius Mulley To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb/m2: add builtin procedure function ADR References: <875xq8x90o.fsf@localhost> <87v7y8ge0f.fsf@tromey.com> <87o73zq4fi.fsf_-_@localhost> <87msjjhh0f.fsf@tromey.com> Date: Fri, 04 Oct 2024 19:52:53 +0100 In-Reply-To: <87msjjhh0f.fsf@tromey.com> (Tom Tromey's message of "Fri, 04 Oct 2024 12:14:56 -0600") Message-ID: <87h69raeey.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Gaius" == Gaius Mulley writes: > > Gaius> Many thanks for the review, here is v2 with a testcase. In v2 the only > Gaius> change is the new file gdb/testsuite/gdb.modula2/builtin-procedure-adr.exp. > > Looks good to me. Thank you. > Approved-By: Tom Tromey > > Tom Many thanks!