From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: Use file_rename_atomic in gdb_do_cache too
Date: Wed, 22 Jul 2026 09:50:15 -0600 [thread overview]
Message-ID: <87v7a7qb0o.fsf@tromey.com> (raw)
In-Reply-To: <ff25f5e6-f7db-4f60-9475-9866901f02ec@palves.net> (Pedro Alves's message of "Wed, 22 Jul 2026 16:20:49 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> gdb_do_cache in cache.exp does the same thing: in GDB_PARALLEL mode,
Pedro> each worker writes the results cache to a per-pid temporary file and
Pedro> then atomically renames it into place, so it can hit the same EBUSY
Pedro> race on Windows. It was missed by that commit.
Pedro> Fix it by using file_rename_atomic there too.
Looks good.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-07-22 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 15:56 [PATCH] Windows: Fix set_unbuffered_mode.o file rename race Pedro Alves
2026-07-21 16:43 ` Tom Tromey
2026-07-22 15:07 ` Pedro Alves
2026-07-22 15:20 ` [PATCH] gdb/testsuite: Use file_rename_atomic in gdb_do_cache too Pedro Alves
2026-07-22 15:50 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7a7qb0o.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox